[Tarantool-patches] [PATCH v2 05/15] lua: don't raise a Lua error from luaT_tuple_new()

Igor Munkin imun at tarantool.org
Sun Oct 11 21:08:50 MSK 2020


Well, I looked to the sources once more :)

On 11.10.20, Igor Munkin wrote:
> Sasha,
> 
> It is not full review, but Vlad asked me offline regarding a passage
> below. So I dump our discussion results.
> 
> On 11.10.20, Alexander Turenko wrote:
> 
> <snipped>
> 
> > +	int top = lua_gettop(L);
> 
> This value can't be used, since <lua_rawgeti> can trigger Lua stack
> reallocation, ergo this value will be invalidated.

This is not the address, but offset, so nevermind.

> 
> > +
> > +	/* Calculate absolute value in the stack. */
> 

<snipped>

> 
> > -- 
> > 2.25.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list