[Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert operation

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Oct 11 18:35:52 MSK 2020


>> Does this patchset change format of vinyl statements on disk? If yes, I guess
>> it breaks backward compatibility. Did you check how does it behave when booted
>> from files of a previous version? Does it crash? Does it report an error? How
>> a user can upgrade his vinyl files to the new format?
> 
> No, everything goes fine except the fact that upsert statements restored
> from disk have ops encoded into single array and as a result being applied
> may break associative property (like it was before this patch). I've tried
> to add a test, but since squash operation modifies content of run/xlog files,
> such test can be run only once. If it is vital, I guess it is possible to
> copy data directory before each test run..

Yes, it is possible. At least it would be better than not having a test at
all.


More information about the Tarantool-patches mailing list