[Tarantool-patches] [PATCH] sql: add missed sqlReleaseTempRange()

Roman Khabibov roman.habibov at tarantool.org
Thu Oct 8 18:33:50 MSK 2020


Hi! Thanks! Nikita, can you see the patch?
https://github.com/tarantool/tarantool/tree/romanhabibov/release-temp-reg

> On Sep 17, 2020, at 17:27, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Hi! Thanks for the patch!
> 
> LGTM.

commit 6eccc4f0b3d107d5963ea10e391ef8924cac381f (HEAD -> romanhabibov/release-temp-reg, origin/romanhabibov/release-temp-reg)
Author: Roman Khabibov <roman.habibov at tarantool.org>
Date:   Sat Sep 12 01:05:29 2020 +0300

    sql: add missed sqlReleaseTempRange()
    
    Clean up temp registers with sqlReleaseTempRange() during check
    constraint alter.

diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c
index 14f6c1a97..4874b46c9 100644
--- a/src/box/sql/alter.c
+++ b/src/box/sql/alter.c
@@ -136,6 +136,7 @@ sql_alter_ck_constraint_enable(struct Parse *parse)
 		      tuple_reg + field_count);
 	sqlVdbeAddOp4(v, OP_IdxReplace, tuple_reg + field_count, 0, 0,
 		      (char *)ck_space, P4_SPACEPTR);
+	sqlReleaseTempRange(parse, tuple_reg, field_count + 1);
 exit_alter_ck_constraint:
 	sqlDbFree(db, constraint_name);
 	sqlSrcListDelete(db, src_tab);



More information about the Tarantool-patches mailing list