[Tarantool-patches] [PATCH v4 2/6] sql: refactor create_table_def and parse

[Roman Khabibov]

Hi! Thanks for the review.

> On Oct 6, 2020, at 00:22, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Hi! Thanks for the patch!
> 
>> diff --git a/src/box/sql/parse_def.h b/src/box/sql/parse_def.h
>> index cb0ecd2fc..21829b6f0 100644
>> --- a/src/box/sql/parse_def.h
>> +++ b/src/box/sql/parse_def.h
>> @@ -500,12 +505,12 @@ create_view_def_init(struct create_view_def *view_def, struct Token *name,
>> }
>> 
>> static inline void
>> -create_table_def_destroy(struct create_table_def *table_def)
>> +create_fkeys_def_destroy(struct create_fkeys_def *fkeys_def)
> 
> Where is create_checks_def destroyed?
There's nothing to destroy in create_checks_def. Or is it worth
creating it to keep the formality?