[Tarantool-patches] [PATCH v4 4/6] sql: use parser's region of "index" array

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Oct 6 00:22:22 MSK 2020


Thanks for the patch!

> diff --git a/src/box/sql/build.c b/src/box/sql/build.c
> index 6cc76bb77..d1d240315 100644
> --- a/src/box/sql/build.c
> +++ b/src/box/sql/build.c
> @@ -2717,7 +2737,7 @@ sql_create_index(struct Parse *parse) {
>  
>  	if (tbl_name != NULL)
>  		goto exit_create_index;
> -	table_add_index(space, index);
> +	sql_space_add_index(&parse->region, space, index);

In case of a fail the error is never checked anywhere. Parse->is_aborted
stays false.


More information about the Tarantool-patches mailing list