[Tarantool-patches] [PATCH 2.X 5/7] module api: luaT_temp_luastate & luaT_release_temp_luastate

[Igor Munkin]

Sasha,

Thanks a lot for the benchmarks and clarifications!

On 30.09.20, Alexander Turenko wrote:
> On Wed, Sep 30, 2020 at 01:23:17AM +0200, Vladislav Shpilevoy wrote:

<snipped>

> 
> The performance difference also looks small (I shared benchmarking results
> in this mailing thread). Since there are questions about design of those
> functions, I would use lua_newthread() (or wrapper around it to handle
> OOM -- written in the module). We can return back to this API later.
> 

Perfect! I would gladly join the discussion and design for the vital
public API interfaces.

<snipped>

> > 
> > It is not that simple. Whatever you export now, we will need to support
> > potentially forever. So exporting not vital things increases support costs
> > for us for a very long time by saving a few time to you and Timur so you
> > don't need to change merger code and can move it as is. I would better
> > one time made merger less depending on Tarantool internals, then do long
> > support of the new pile of internal methods exposed in a hurry.
> 
> I agree, but also I consider this activity as good opportunity to
> improve the module API. Of course, when we have good design.

I agree with Vlad here. I totally understand your motivation but I
strongly doubt we should mix these issues (i.e. exporting the methods
necessary for merger and public API enhancements).

-- 
Best regards,
IM