[Tarantool-patches] [PATCH v1 1/1] temporary: locate missing diag in VDBE

imeevma at tarantool.org imeevma at tarantool.org
Fri Nov 27 13:44:34 MSK 2020


---
https://github.com/tarantool/tarantool/issues/5537
https://github.com/tarantool/tarantool/tree/imeevma/gh-5537-find-missing-diag

 src/box/sql/vdbe.c    | 3 +++
 src/box/sql/vdbeInt.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
index 724bc188b..ae3dd2028 100644
--- a/src/box/sql/vdbe.c
+++ b/src/box/sql/vdbe.c
@@ -862,6 +862,7 @@ int sqlVdbeExec(Vdbe *p)
 	}
 #endif
 	for(pOp=&aOp[p->pc]; 1; pOp++) {
+		p->pOp = pOp;
 		/* Errors are detected by individual opcodes, with an immediate
 		 * jumps to abort_due_to_error.
 		 */
@@ -5361,6 +5362,8 @@ default: {          /* This is really OP_Noop and OP_Explain */
 abort_due_to_error:
 	rc = -1;
 	p->is_aborted = true;
+	if (diag_is_empty(&fiber()->diag))
+		abort();
 
 	/* This is the only way out of this procedure. */
 vdbe_return:
diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
index 2c50b6768..24915bcf5 100644
--- a/src/box/sql/vdbeInt.h
+++ b/src/box/sql/vdbeInt.h
@@ -411,6 +411,7 @@ struct Vdbe {
 	 */
 
 	Op *aOp;		/* Space to hold the virtual machine's program */
+	Op *pOp;
 	Mem *aMem;		/* The memory locations */
 	Mem **apArg;		/* Arguments to currently executing user function */
 	/** SQL metadata for DML/DQL queries. */
-- 
2.25.1



More information about the Tarantool-patches mailing list