[Tarantool-patches] [PATCH v2 2/3] cfg: support symbolic evaluation of replication_synchro_quorum

Cyrill Gorcunov gorcunov at gmail.com
Wed Nov 25 15:19:07 MSK 2020

On Wed, Nov 25, 2020 at 03:10:48PM +0300, Serge Petrenko wrote:
> > > > +box_renew_replication_synchro_quorum(void)
> > > What do you think of `box_update_replication_synchro_quorum`?
> > I don't mind with any name, so I'llupdate it to match.
> > 
> > You know the most thing which bothers me most is the fact
> > that we're calling box function from a deep code chain of
> > replication engine. replica_set/clear helpers are bound to
> > replication internals and ideally should know nothing about
> > box configuration that's why I thought of some kind of
> > notification hooks or triggers.
> > 
> > Say replicaset allocates a trigger on init and allow any code
> > to be notified with stage changes. In our case the stage is replica
> > id set or clear. Thus box could setup a trigger into replicaset
> > and we simply run the trigger. For me this would look a way
> > more natural but I'm not sure, because this will require to
> > introduce "stages" and instead of a single call to box_ we
> > will have a way more bigger patch with unclear picture...
> > Simply dunno.
> I see. I'm not sure we need to implement this.
> IMO it looks ok now. Let's wait for Vladislav's opinion.

Sure, I'm fine with leaving it as a direct call for now.

More information about the Tarantool-patches mailing list