[Tarantool-patches] [PATCH 00/11] qsync: code refactoring
Alexander V. Tikhonov
avtikhon at tarantool.org
Wed Nov 25 00:41:08 MSK 2020
Hi Cyrill, thanks for the patch, as I see no new degradation found in
gitlab-ci testing commit criteria pipeline , patch LGTM.
 - https://gitlab.com/tarantool/tarantool/-/pipelines/220256606
On Tue, Nov 24, 2020 at 09:52:47AM +0300, Cyrill Gorcunov wrote:
> On Tue, Nov 24, 2020 at 12:26:04AM +0100, Vladislav Shpilevoy wrote:
> > Hi!
> > Alexander (Tikh.), please, validate that we can push branch
> > gorcunov/qsync-refactoring, to which I cherry-picked the
> > LGTM commits.
> > Cyrill, for the first commit I don't know what to do.
> > All the files you listed you use personally in your
> > workspace, it seems. If we would add everything what we
> > have locally there, the file would end up as a pile of
> > garbage. I can't make a decision to push anything new there.
> > I suggest you to send it to somebody else. For example,
> > Alexander (Turenko).
> Vlad, I'm pretty fine if we simply drop the series. Sorry
> if I was somehow emotional in my replies :)
> I think the main reason for series was my attempt to figure
> out some limbo internals especially rollback and queue management,
> so the series is a side effect. Lets just rip the series off and forget )
More information about the Tarantool-patches