[Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings

Oleg Babin olegrok at tarantool.org
Tue Nov 24 22:23:11 MSK 2020

Thanks for review!

On 24/11/2020 18:20, Igor Munkin wrote:
> Oleg,
> Thanks for the patch! Considering the version on the remote branch, LGTM
> except a single nit below.
> On 18.11.20,olegrok at tarantool.org  wrote:
>> From: Oleg Babin<babinoleg at mail.ru>
>> Before this patch it was impossible to compare uuid values with
>> string representations of uuid. However we have cases when such
>> comparisons is possible (e.g. "decimal" where we can compare
>> decimal values with strings and numbers).
>> This patch extends uuid comparators (eq, lt, le) and every string
> Minor: Strictly saying, you're right, but AFAICS we usually use the key
> name (i.e. __eq, __le and __lt) for metamethods in description.

I've updated and force-pushed branch. I cite only changed part:

     This patch extends uuid comparators (__eq, __lt and __le) and
     every string argument is tried to be converted to uuid value to
     compare then.

More information about the Tarantool-patches mailing list