[Tarantool-patches] [PATCH 1/4] replication: run clear_synchro_queue() with unconfigured box
sergeyb at tarantool.org
Mon Nov 23 17:44:25 MSK 2020
Hi! Thanks for review!
On 21.11.2020 17:41, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> From the commit title it seems like you introduced a feature to run
> the function with non-configured box. Please, change 'run' to 'test',
> would be better already.
> Also for qsync we usually write title 'qsync: ...', not just
> 'replication: ...'. Or in your case it could be 'test: ...',
> but up to you. The same for the other commits.
updated prefix for all commits in patch series:
4f8b516c3 (HEAD -> ligurio/gh-4842-qsync-testing) qsync: add test with
change space sync mode in a loop
d9a3fff52 qsync: add test with random leaders promotion and demotion
8723e4cca qsync: test clear_synchro_queue() function
8889406fc qsync: test clear_synchro_queue() with unconfigured box
> The patch itself is good.
More information about the Tarantool-patches