[Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk and network

[Serge Petrenko]

20.11.2020 22:40, Vladislav Shpilevoy пишет:
>>>>> diff --git a/src/box/raft.c b/src/box/raft.c
>>>>> index af6e71e0b..845525660 100644
>>>>> --- a/src/box/raft.c
>>>>> +++ b/src/box/raft.c
>>>>> @@ -29,7 +29,10 @@
>>>>>      * SUCH DAMAGE.
>>>>>      */
>>>>>     #include "box.h"
>>>>> +#include "error.h"
>>>>> +#include "journal.h"
>>>>>     #include "raft.h"
>>>>> +#include "relay.h"
>>>>>     #include "replication.h"
>>>> Just noticed: raft.c starts depending on xrow.h in this patch.
>>> This is fine. box/raft.c can depend on anything. It is raftlib.c/.h,
>>> who is not allowed to depend on anything except src/lib.
>> I meant you should include xrow.h here directly.
> Aha, ok. I thought that it is enough to have it implicitly through other
> files. But I don't mind adding it.
>
> ====================
> @@ -34,6 +34,7 @@
>   #include "raft.h"
>   #include "relay.h"
>   #include "replication.h"
> +#include "xrow.h"


Thanks for the change!

Yes, it's enough to have it included in some other file, but AFAIR we always
include dependencies directly. Either in raft.h (if needed) or raft.c in 
this case.

I may be mistaken though.

-- 
Serge Petrenko