[Tarantool-patches] [PATCH 00/11] qsync: code refactoring
v.shpilevoy at tarantool.org
Sat Nov 21 02:54:54 MSK 2020
Hi! Thanks for the patchset!
I won't explain again (third or forth time, I don't remember), why
we don't do refactoring for the sake of refactoring. You can find it
in the mailing list and re-read, if you want. Sorry if sounds rude,
but I give up after explaining it so many times. So I will simply write
NACK for the commits, which literally don't do anything except
subjectively 'more readable' changes.
If you disagree, respond to my emails why concretely. It means you
can prove that the commit fixes a bug, or fixes some serious flaw in
the code style which makes the code look corrupted and totally
unreadable with wrong variable names etc, or it reduces some huge
code duplication. Other things are subjective.
Commits 2, 3, 5, 11 LGTM. I will commit them when the rest of the patches
are reviewed, discussed, and everyone agrees with the decisions.
More information about the Tarantool-patches