[Tarantool-patches] [PATCH 2/2] box: use tuple_field_raw_by_part where possible

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Nov 21 02:26:55 MSK 2020

Thanks for the patch!

On 14.11.2020 18:28, Serge Petrenko wrote:
> tuple_field_raw_by_part allows to use part's offset slot cache to bypass
> tuple field lookup in a JSON tree, which is involved even for plain
> tuples.

I am not sure I understand. How does it work in 1.10 then? It uses
tuple_field_by_part_raw, which in the end simply calls

	tuple_field_raw(format, data, field_map, part->fieldno);

Exactly what we had here. Why did anything change?

> Since both tuple_field_raw_by_part and tuple_field_raw are basically
> aliases to tuple_field_raw_by_path, prefer the former to the latter,
> since it takes advantage over key part's offset slot cache.
Besides, I can't find any info why do we need this 'offset slot cache'.
The comment above this member simply narrates the code, and I don't
understand the actual reason it was added. Did you manage to realize it?
Can you explain, please?

More information about the Tarantool-patches mailing list