[Tarantool-patches] [RFC 2/4] qsync: move synchro quorum update to separate routine

Serge Petrenko sergepetrenko at tarantool.org
Fri Nov 20 14:39:03 MSK 2020

20.11.2020 14:01, Cyrill Gorcunov пишет:
> On Fri, Nov 20, 2020 at 01:06:55PM +0300, Serge Petrenko wrote:
>> IMO it'd be better to name the new function somewhat similar  to
>> `box_update_replication_synchro_quorum` and leave it in box.cc
>> This way you avoid adding 2 new dependencies to replication.cc
>> and leave all the code dealing with reconfiguration at one place.
>> Besides, replication.cc already depends on box, so it won't be a problem
>> to call update_replication_synchro_quorum there.
> Yeah, I don't mind, thanks!
>> Load_cfg.lua will say something similar, when replication_synchro_quorum is
>> a number:
>> ```
>>              log.info("set '%s' configuration option to %s", key,
>>                  json.encode(val))
>> ```
>> So this say_info belongs to the trigger you invoke on replica
>> register/unregister.
> It will say "set ... to n+2/1" while we're printing the evaluated
> integer value which is more informative.

Yes, but when it's actually  configured to number, there'll be duplicate 

You already have the needed log message in the next commit.

Serge Petrenko

More information about the Tarantool-patches mailing list