[Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Fri Nov 20 02:42:29 MSK 2020


Hi! Thanks for the review!

>> diff --git a/src/box/raft.c b/src/box/raft.c
>> index f289a6993..af6e71e0b 100644
>> --- a/src/box/raft.c
>> +++ b/src/box/raft.c
>> @@ -62,6 +63,57 @@ box_raft_on_update_f(struct trigger *trigger, void *event)
>>  	return 0;
>>  }
>>  
>> +void
>> +box_raft_reconsider_election_quorum(void)
> 
> Suggestion: maybe use "rewrite"/"reset" instead of "reconsider"?
> Or plain "update"?
> 
> Other than that, LGTM.

I took "update". Now it is box_raft_update_election_quorum().


More information about the Tarantool-patches mailing list