[Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc Lua module

Cyrill Gorcunov gorcunov at gmail.com
Fri Nov 13 20:54:33 MSK 2020

On Thu, Nov 12, 2020 at 11:53:35PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
> I am going to ask you to send responses to my comments in a
> format of diff hunks fixing the comments. Usually you rush to
> answer to my comments the same day they are sent with some
> promises like "I will take a look", "I will see what can be done",
> etc. But then you send a new version of the patchset without
> responding to my comments with what you actually did regarding
> each of them.
> That makes me go through the comments on my own and look for the
> commented places in the new patch to see the difference. It takes
> significant time.
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#during-the-review
> Point 1.

OK. I did the whole resend simply thought you gonna be more comfortable with.

More information about the Tarantool-patches mailing list