[Tarantool-patches] [PATCH 04/11] txn: txn_commit_async -- drop redundant variable

Serge Petrenko sergepetrenko at tarantool.org
Fri Nov 13 12:31:47 MSK 2020


12.11.2020 22:51, Cyrill Gorcunov пишет:
> We use it once so it is simply redundant.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>   src/box/txn.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/box/txn.c b/src/box/txn.c
> index a075c9ef0..64f01f4e0 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -815,9 +815,8 @@ txn_commit_async(struct txn *txn)
>   	if (req == NULL)
>   		goto rollback;
>   
> -	bool is_sync = txn_has_flag(txn, TXN_WAIT_SYNC);
>   	struct txn_limbo_entry *limbo_entry;
> -	if (is_sync) {
> +	if (txn_has_flag(txn, TXN_WAIT_SYNC)) {
>   		/*
>   		 * We'll need this trigger for sync transactions later,
>   		 * but allocation failure is inappropriate after the entry
LGTM

-- 
Serge Petrenko



More information about the Tarantool-patches mailing list