[Tarantool-patches] [PATCH] lua: introduce function for uuid comparison
sergeyb at tarantool.org
Fri Nov 13 09:37:45 MSK 2020
On 12.11.2020 12:55, Oleg Babin wrote:
> Hi, Sergey!
> The main reason is "uuid tests were implemented with diff-based approach".
Got it. Missed it that you haven't add new test and just enhanced the
> However I can easily convert my tests to TAP but I don't want touch
> existing tests of course.
> Do you think we should start moving towards TAP-based approach for
> "uuid" module testing?
I think no.
> On 12/11/2020 12:44, Sergey Bronnikov wrote:
>> Hi, Oleg
>> thanks for the patch!
>> Looks like you expect a review from Leonid and Vlad, but I have a
>> question regarding tests in the patch.
>> On 23:04 Wed 11 Nov , olegrok at tarantool.org wrote:
>>> --- a/test/app/uuid.result
>>> +++ b/test/app/uuid.result
>> For Tarantool core we have two kind of tests: with diff-based approach
>> and TAP based tests. Your tests can be easily implemented with a TAP
>> approach, when test data and oracle are in the code. But you preferred a
>> diff-based approach here. Why?
More information about the Tarantool-patches