[Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap

[Alexander Turenko]

On Fri, Nov 06, 2020 at 02:47:00AM +0300, Alexander Turenko wrote:
> Thanks for the effort!
> 
> Just `luacheck .` shows the following warnings, for example:
> 
> test/sql-tap/minmax2.test.lua:64:9: setting non-standard global variable sql_search_count
> test/sql-tap/subquery.test.lua:696:9: setting non-standard global variable callcnt
> 
> It seems, `make luacheck` target does not work.
> 
>  | $ make VERBOSE=1 luacheck
>  | <...>
>  | /usr/bin/luacheck --codes --config                \
>  |     /home/alex/p/tarantool-meta/r/t-3/.luacheckrc \
>  |     /home/alex/p/tarantool-meta/r/t-3
>  | <...>
> 
> If I run luacheck this way, it does not give any warnings. This does not
> look as the problem from your patch, but it is something we should fix
> prior it.

Found problems on the luacheck side (at least it looks so) and
implemented the workaround for tarantool:

https://github.com/mpeterv/luacheck/issues/208
https://github.com/tarantool/tarantool/commit/a1d2ce9a758ac1bbf7173cf197eea3f1556b7cb4

The workaround looks a bit tricky, so I'm not sure whether it worth to
push it. I'll think around it a bit more and maybe will sent it for
review.