[Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap
alexander.turenko at tarantool.org
Wed Nov 11 11:17:13 MSK 2020
On Fri, Nov 06, 2020 at 02:47:00AM +0300, Alexander Turenko wrote:
> Thanks for the effort!
> Just `luacheck .` shows the following warnings, for example:
> test/sql-tap/minmax2.test.lua:64:9: setting non-standard global variable sql_search_count
> test/sql-tap/subquery.test.lua:696:9: setting non-standard global variable callcnt
> It seems, `make luacheck` target does not work.
> | $ make VERBOSE=1 luacheck
> | <...>
> | /usr/bin/luacheck --codes --config \
> | /home/alex/p/tarantool-meta/r/t-3/.luacheckrc \
> | /home/alex/p/tarantool-meta/r/t-3
> | <...>
> If I run luacheck this way, it does not give any warnings. This does not
> look as the problem from your patch, but it is something we should fix
> prior it.
Found problems on the luacheck side (at least it looks so) and
implemented the workaround for tarantool:
The workaround looks a bit tricky, so I'm not sure whether it worth to
push it. I'll think around it a bit more and maybe will sent it for
More information about the Tarantool-patches