[Tarantool-patches] [PATCH 3/4] raft: add explicit raft argument to all functions
v.shpilevoy at tarantool.org
Tue Nov 10 03:00:13 MSK 2020
Thanks for the review!
>> @@ -535,7 +538,6 @@ raft_write_cb(struct journal_entry *entry)
>> static void
>> raft_write_request(const struct raft_request *req)
>> - assert(raft.is_write_in_progress);
> Not related to this patch, just a thought.
> Looks like raft_write_request belongs to some other file now.
> Will you move it somewhere else?
> I don't know where to put it though. box.cc?
Yes, this is what I am going to do in the end. When I will move
raft to src/lib/raft, some box-specific functions will stay in
The raft library will use them as virtual functions.
I will unbind raft from box in Part 2 of my work on this issue.
More information about the Tarantool-patches