[Tarantool-patches] [PATCH v1] test: fix hang of vinyl/select_consistency.* test
Alexander V. Tikhonov
avtikhon at tarantool.org
Mon Nov 9 15:57:12 MSK 2020
During testing process:
https://gitlab.com/tarantool/tarantool/-/jobs/800863457#L5303
found that test vinyl/select_consistency.test.lua hanged:
--- vinyl/select_consistency.result Thu Jun 11 11:59:48 2020
+++ var/152_vinyl/select_consistency.result Tue Oct 20 09:13:02 2020
@@ -137,16 +137,3 @@
for i = 1, ch:size() do
ch:get()
end;
----
-...
-test_run:cmd("setopt delimiter ''");
----
-- true
-...
This issue stops the testing till the complete timeout of the test-run
will stop all the testing process. To avoid of it 'wait_cond()' routine
was added to 'ch:get()' command to set it's local timeout to avoid of
waiting for test-run global timeout.
Needed for #4385
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4385_hang_select_consistency
Issue: https://github.com/tarantool/tarantool/issues/4385
test/vinyl/select_consistency.result | 2 +-
test/vinyl/select_consistency.test.lua | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/vinyl/select_consistency.result b/test/vinyl/select_consistency.result
index f27d0ec68..5a23a674b 100644
--- a/test/vinyl/select_consistency.result
+++ b/test/vinyl/select_consistency.result
@@ -135,7 +135,7 @@ stop = true;
---
...
for i = 1, ch:size() do
- ch:get()
+ test_run:wait_cond(function() return ch:get() end)
end;
---
...
diff --git a/test/vinyl/select_consistency.test.lua b/test/vinyl/select_consistency.test.lua
index 73b443e89..6398d09cd 100644
--- a/test/vinyl/select_consistency.test.lua
+++ b/test/vinyl/select_consistency.test.lua
@@ -102,7 +102,7 @@ end;
stop = true;
for i = 1, ch:size() do
- ch:get()
+ test_run:wait_cond(function() return ch:get() end)
end;
test_run:cmd("setopt delimiter ''");
--
2.25.1
More information about the Tarantool-patches
mailing list