[Tarantool-patches] [PATCH] raft: use vclock_map_t for voting tracking

Cyrill Gorcunov gorcunov at gmail.com
Fri Nov 6 11:37:24 MSK 2020

We've VCLOCK_MASK constant which limits the number of
regular nodes in a replication cluster. This limit is
bound to the vclock_map_t bitset type. Thus when we're
tacking voting process in Raft node we better use this
type for vote_mask member (otherwise it is a room for
error if we ever change VCLOCK_MASK and extend the width
of a bitset).

Suggested-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
branch gorcunov/raft-vote-mask

 src/box/raft.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/box/raft.h b/src/box/raft.h
index 8293d7410..0e7fe0e85 100644
--- a/src/box/raft.h
+++ b/src/box/raft.h
@@ -33,6 +33,7 @@
 #include <stdbool.h>
 #include "tarantool_ev.h"
 #include "trigger.h"
+#include "vclock.h"
 #if defined(__cplusplus)
 extern "C" {
@@ -146,7 +147,7 @@ struct raft {
 	 * Bit 1 on position N means that a vote from instance with ID = N was
 	 * obtained.
-	uint32_t vote_mask;
+	vclock_map_t vote_mask;
 	/** Number of votes for this instance. Valid only in candidate state. */
 	int vote_count;
 	/** State machine timed event trigger. */

More information about the Tarantool-patches mailing list