[Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write

Cyrill Gorcunov gorcunov at gmail.com
Mon Nov 2 14:48:01 MSK 2020


On Sat, Oct 31, 2020 at 07:01:40PM +0100, Vladislav Shpilevoy wrote:
> The function is called only by the journal when write is finished.
> 
> Besides, it may not complete the transaction. In case of
> synchronous replication it is not enough for completion. It means,
> it can't have 'complete' in its name.
> 
> Also the function is never used out of txn.c, so it is removed
> from txn.h and is now static.
> 
> The patch is a preparation for not spaming "too long WAL write" on
> synchronous transactions, because it is simply misleading.
> 
> Part of #5139
Ack


More information about the Tarantool-patches mailing list