[Tarantool-patches] [PATCH v6 06/25] Fix luacheck warnings in src/box/lua/

Sergey Bronnikov sergeyb at tarantool.org
Sat May 30 15:22:13 MSK 2020


Igor,

thanks for review!

On 22:11 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! It LGTM, except the one comment: if LuaJIT std is
> set, suppressions for bit global can be omitted.

global 'bit' is now omitted

> On 29.05.20, sergeyb at tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb at tarantool.org>
> > 
> > Part of #4681
> > 
> > Reviewed-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> > Co-authored-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> > ---
> >  .luacheckrc                     |  9 +++++-
> >  src/box/lua/console.lua         |  6 ++--
> >  src/box/lua/feedback_daemon.lua |  2 +-
> >  src/box/lua/key_def.lua         |  2 +-
> >  src/box/lua/load_cfg.lua        | 31 +++++++++----------
> >  src/box/lua/net_box.lua         | 55 +++++++++++++--------------------
> >  src/box/lua/schema.lua          | 50 +++++++++++++++---------------
> >  src/box/lua/tuple.lua           |  8 ++---
> >  src/box/lua/upgrade.lua         | 19 ++++++------
> >  9 files changed, 87 insertions(+), 95 deletions(-)
> > 
> > diff --git a/.luacheckrc b/.luacheckrc
> > index 4d95f2729..03a51ba3e 100644
> > --- a/.luacheckrc
> > +++ b/.luacheckrc
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@


More information about the Tarantool-patches mailing list