[Tarantool-patches] [PATCH] vinyl: add NULL check of xrow_upsert_execute() retval

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [20/05/30 00:29]:

> I don't know how to fix it in a simple way. The only thing I could
> come up with is probably don't squash such fat upserts. Just keep
> them all on the disk, until they eventually meet bottom of their key,
> or a terminal statement like REPLACE/INSERT/DELETE.

I wrote earlier about this problem in @tarantoolru.

We need to balance the op limit and the squash threshold (how many
upserts we keep before forcing a squash) so that
accumulation before squash can never lead to going out of the op limit.

Basically, we should force squash before we have a chance of
creating an invalid upsert.

We could even have a separate constant - number of ops in *user*
upsert, which == 
max_number_of_ops/max_upserts_before_forced_squash.

-- 
Konstantin Osipov, Moscow, Russia