[Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck

Igor Munkin imun at tarantool.org
Fri May 29 22:25:16 MSK 2020


Sergey,

Thanks for the patch! It LGTM, except the one comment: I'm not a Gitlab
CI expert but since you introduced a separate make rule for luacheck, it
looks like you can use it also in CI. As a result of such change we have
a single place where luacheck command is mentioned excplicitly in our
project, that simplifies further maintenance.

On 29.05.20, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
> 
> Part of #4681
> ---
>  .gitlab-ci.yml | 11 +++++++++++
>  .travis.mk     | 17 +++++++++++++++++
>  2 files changed, 28 insertions(+)
> 

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list