[Tarantool-patches] [PATCH v6 01/25] Add initial luacheck config
Igor Munkin
imun at tarantool.org
Fri May 29 19:04:29 MSK 2020
Sergey,
Thanks for the patch! Here is my comment from previous series[1]:
| Several chunks in test/vinyl/ directory are not diff-based tests but
| either instance configs (e.g. test/vinyl/vinyl.lua) or auxiliary modules
| (e.g. test/vinyl/large.lua). I guess we need to check at least the
| latter ones.
I meant to change file mask for *all* test/ subdirectories in exclude
list the following way: s/\*.lua$/\*.test.lua/g.
Otherwise, LGTM.
On 29.05.20, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
>
> config includes all files with Lua source code except:
> - third_party repositories
> - directories with diff-based tests
>
> How-to check:
>
> $ tarantoolctl rocks install luacheck
> $ .rocks/bin/luacheck --codes --config .luacheckrc .
>
> Part of #4681
>
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> ---
> .luacheckrc | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 .luacheckrc
>
<snipped>
> --
> 2.23.0
>
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017073.html
--
Best regards,
IM
More information about the Tarantool-patches
mailing list