[Tarantool-patches] [PATCH v4 2/8] lua/log: declare say_logger_init and say_logger_initialized

lvasiliev lvasiliev at tarantool.org
Thu May 28 14:12:26 MSK 2020


Hi! Thank you for the patch.
LGTM, except a comment below.

On 28.05.2020 13:07, Cyrill Gorcunov wrote:
> We gonna use it to provide a way to initialize
> logger subsystem early.
> 
> Part-of #689
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>   src/lua/log.lua | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/lua/log.lua b/src/lua/log.lua
> index 312c14d5e..9830b0886 100644
> --- a/src/lua/log.lua
> +++ b/src/lua/log.lua
> @@ -1,5 +1,7 @@
>   -- log.lua
>   --
> +-- vim: ts=4 sw=4 et

Elders must decide whether or not to use vim ...

> +
>   local ffi = require('ffi')
>   ffi.cdef[[
>       typedef void (*sayfunc_t)(int level, const char *filename, int line,
> @@ -22,6 +24,12 @@ ffi.cdef[[
>       void
>       say_set_log_format(enum say_format format);
>   
> +    extern void
> +    say_logger_init(const char *init_str, int level, int nonblock,
> +                    const char *format, int background);
> +
> +    extern bool
> +    say_logger_initialized(void);
>   
>       extern sayfunc_t _say;
>       extern struct ev_loop;
> 


More information about the Tarantool-patches mailing list