[Tarantool-patches] [PATCH v4 8/8] test: use direct log module

Cyrill Gorcunov gorcunov at gmail.com
Thu May 28 13:50:16 MSK 2020


On Thu, May 28, 2020 at 01:42:32PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch. See several comments below.
> 
> On 28/05/2020 13:07, Cyrill Gorcunov wrote:
> > To test if we can setup logging module before the box/cfg{}.
> 
> nit: `box.cfg{}`, not `box/cfg{}`

Thanks!

> > +--
> > +-- gh-689: Operate with logger via log module without calling box.cfg{}
> 
> As we've discussed it's better to add "negative" cases to tests.
> There are examples, e.g. https://github.com/tarantool/tarantool/blob/master/test/app-tap/yaml.test.lua#L86

Yes, thanks a huge!


More information about the Tarantool-patches mailing list