[Tarantool-patches] [PATCH v4 4/8] lua/log: do not allow to set json for boot logger

[Cyrill Gorcunov]

On Thu, May 28, 2020 at 01:40:25PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch see one comment below.
> 
> > diff --git a/test/app-tap/logger.test.lua b/test/app-tap/logger.test.lua
> > index 492d5ea0b..7bfa06e80 100755
> > --- a/test/app-tap/logger.test.lua
> > +++ b/test/app-tap/logger.test.lua
> > @@ -5,7 +5,6 @@ test:plan(24)
> >   -- gh-3946: Assertion failure when using log_format() before box.cfg()
> >   local log = require('log')
> > -log.log_format('json')
> 
> I think you can change it to "pcall(log.log_format, 'json')" and check that
> it returns an error. Not simply drop a test case.

Good catch! Thanks, will update!