[Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger

lvasiliev lvasiliev at tarantool.org
Thu May 28 13:42:01 MSK 2020


Hi! Thank you for the patch.
I have a minor comment that can be skipped silently.

> diff --git a/src/lib/core/say.h b/src/lib/core/say.h
> index c50d7bbf4..857145465 100644
> --- a/src/lib/core/say.h
> +++ b/src/lib/core/say.h
> @@ -274,6 +274,10 @@ say_logger_init(const char *init_str,
>   		const char *log_format,
>   		int background);
>   
> +/** Test if logger is initialized. */
> +bool
> +say_logger_initialized(void);
> +

I think this function may be used for the check in say_logger_free()
instead log_default == &log_std.
>   /** Free default logger */
>   void
>   say_logger_free();
> 


More information about the Tarantool-patches mailing list