[Tarantool-patches] [PATCH v5 03/10] Fix luacheck warnings in extra/dist/tarantoolctl.in
Igor Munkin
imun at tarantool.org
Wed May 27 02:11:46 MSK 2020
Sergey,
Thanks for the patch! I see there are several changes since v4, so I
re-checked these changeset one more time. Please consider a single nit
below. Otherwise, LGTM.
On 12.05.20, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
>
> Closes #4681
>
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Reviewed-by: Igor Munkin <imun at tarantool.org>
>
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Co-authored-by: Igor Munkin <imun at tarantool.org>
> ---
> .luacheckrc | 5 +++++
> extra/dist/tarantoolctl.in | 33 +++++++++++----------------------
> 2 files changed, 16 insertions(+), 22 deletions(-)
>
> diff --git a/.luacheckrc b/.luacheckrc
> index 2683c8c26..f39502063 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -24,3 +24,8 @@ exclude_files = {
> ".rocks/**/*.lua",
> ".git/**/*.lua",
> }
> +
> +files["extra/dist/tarantoolctl.in"] = {
> + globals = {"box", "_TARANTOOL"},
> + ignore = {"212/self", "122", "431"}
> +}
Typo: there is a little mess with whitespace above:
* tabs are used instead of spaces for indentation
* trailing whitespace (but I don't see it on branch)
<snipped>
> --
> 2.23.0
>
--
Best regards,
IM
More information about the Tarantool-patches
mailing list