[Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static analysis with luacheck

Igor Munkin imun at tarantool.org
Wed May 27 01:39:32 MSK 2020


Sergey,

Thanks, the patch LGTM, except a single nit I left below, please
consider it.

On 12.05.20, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
> 
> Closes #4681
> ---
>  .gitlab-ci.yml | 11 +++++++++++
>  .travis.mk     | 17 +++++++++++++++++
>  2 files changed, 28 insertions(+)
> 

<snipped>

> diff --git a/.travis.mk b/.travis.mk
> index 8aa0e6116..3c8e627d0 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -6,6 +6,8 @@ DOCKER_IMAGE?=packpack/packpack:debian-stretch
>  TEST_RUN_EXTRA_PARAMS?=
>  MAX_FILES?=65534
>  MAX_PROC?=2500
> +LANES_ROCKSPEC="https://luarocks.org/manifests/benoitgermain/lanes-3.13.0-0.rockspec"

This constant seems to be unused, so can be dropped.

> +OOS_SRC_PATH="/source"
>  
>  all: package
>  

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list