[Tarantool-patches] [PATCH 1/2] Copy DSO module before load instead of symlink-ing

Konstantin Osipov kostja.osipov at gmail.com
Mon May 25 19:45:01 MSK 2020


* Cyrill Gorcunov <gorcunov at gmail.com> [20/05/25 18:23]:

> On Mon, May 25, 2020 at 05:34:19PM +0300, Konstantin Osipov wrote:
> > 
> > > +	off_t pos, left;
> > > +	for (left = st.st_size, pos = 0; left > 0;) {
> > > +		off_t ret = eio_sendfile_sync(dest_fd, source_fd, pos,
> > > +					      st.st_size);
> > 
> > I wonder why do you use eio_sendfile_sync()?
> > 
> > I don't know why coio_copyfile uses it BTW. Why is eio_sendfile()
> > not enough?
> 
> ```
> eio_ssize_t
> eio_sendfile_sync (int ofd, int ifd, off_t offset, size_t count)
> {
>   return eio__sendfile (ofd, ifd, offset, count);
> }
> ```
> 
> They are simply alias to each other.

Right, but one is public api and the other is not?

Check eio.pod please.

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list