[Tarantool-patches] [PATCH 1/2] Copy DSO module before load instead of symlink-ing

[Konstantin Osipov]

* Kirill Yukhin <kyukhin at tarantool.org> [20/05/20 12:54]:
> +	int ch;
> +	while( ( ch = fgetc(source) ) != EOF )
> +		fputc(ch, target);


This code looks like it is copied from stackoverflow?
For one, it does not follow Tarantool coding style. 
and it's copying the file one byte at a time, good at least it's
in buffered mode?!

> +	fclose(source);
> +	fclose(target);


Please use libeio or, as last resort, sendfile().

Tarantool is a single threaded high-performance database and
application server. It's not OK to block the event loop for a few
hundred thousand instructions (and here we can easily get
millions).


-- 
Konstantin Osipov, Moscow, Russia