[Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization

Oleg Babin olegrok at tarantool.org
Mon May 18 15:03:54 MSK 2020


Hi! Thanks for your patch. LGTM.

On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> For better maintainance.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>   src/box/lua/console.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/box/lua/console.c b/src/box/lua/console.c
> index b941f50c6..d937d684e 100644
> --- a/src/box/lua/console.c
> +++ b/src/box/lua/console.c
> @@ -582,9 +582,9 @@ tarantool_lua_console_init(struct lua_State *L)
>   	 */
>   	lua_setfield(L, -2, "formatter");
>   	struct session_vtab console_session_vtab = {
> -		/* .push = */ console_session_push,
> -		/* .fd = */ console_session_fd,
> -		/* .sync = */ generic_session_sync,
> +		.push	= console_session_push,
> +		.fd	= console_session_fd,
> +		.sync	= generic_session_sync,
>   	};
>   	session_vtab_registry[SESSION_TYPE_CONSOLE] = console_session_vtab;
>   	session_vtab_registry[SESSION_TYPE_REPL] = console_session_vtab;
> 


More information about the Tarantool-patches mailing list