[Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers

[Nikita Pettik]

On 13 May 23:48, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> On 13/05/2020 23:06, Nikita Pettik wrote:
> > On 12 May 01:45, Vladislav Shpilevoy wrote:
> >> +
> >> +static int
> >> +msgpack_fprint_ext(FILE *file, const char **data, int depth)
> >> +{
> >> +	int8_t type;
> >> +	uint32_t len = mp_decode_extl(data, &type);
> >> +	switch(type) {
> >> +	case MP_DECIMAL:
> >> +		return mp_fprint_decimal(file, data, len);
> >> +	case MP_UUID:
> >> +		return mp_fprint_uuid(file, data, len);
> >> +	case MP_ERROR:
> >> +		return mp_fprint_error(file, data, depth);
> >> +	default:
> >> +		return fprintf(file, "undefined");
> > 
> > I'd come up with more sensible message in case of "undefined" mp_ type.
> > For instance: ("undefined mgpack extension (%d)", type).
> 
> This is not an error message.

I understand that. Still I stick to the point that simple "undefined"
looks poor.

> This is a JSON value (even though it is
> not considered standard). Msgpuck prints it, when does not know what else
> do with the type.
 
> This was the case for all MP_EXT so far, they were printed as 'undefined'.
> Now only unknown are 'undefined'.