[Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking

Alexander Turenko alexander.turenko at tarantool.org
Wed May 13 01:18:02 MSK 2020


This patchset provides several fixes for box.execute() and box.cfg()
functions when they are called under various circumstances: when a
function is saved before box loading and called after it, when a
function is called during box loading.

Existence of this patchset does not mean that we'll not implement
https://github.com/tarantool/tarantool/issues/4726: I don't know whether
we will do or will not, but I intend to fix bugs in the existing code.

https://github.com/tarantool/tarantool/issues/4231
Totktonada/gh-4231-box-execute-idempotence

My review is not more sufficient, because I became co-author of the
patchset. Igor, can you, please, review it and pass to a second reviewer
(I suggest Vlad)?

Alexander Turenko (1):
  box: always wait box loading in box.execute()

Maria (2):
  box: check whether box is loaded in box.execute()
  box: always reconfigure box at non-first box.cfg()

 src/box/lua/load_cfg.lua                      | 97 +++++++++++++++++--
 .../gh-4231-box-cfg-idempotence.test.lua      | 34 +++++++
 .../gh-4231-box-execute-idempotence.test.lua  | 37 +++++++
 .../gh-4231-box-execute-locking.test.lua      | 69 +++++++++++++
 test/box-tap/suite.cfg                        |  6 ++
 test/box-tap/suite.ini                        |  1 +
 6 files changed, 237 insertions(+), 7 deletions(-)
 create mode 100755 test/box-tap/gh-4231-box-cfg-idempotence.test.lua
 create mode 100755 test/box-tap/gh-4231-box-execute-idempotence.test.lua
 create mode 100755 test/box-tap/gh-4231-box-execute-locking.test.lua
 create mode 100644 test/box-tap/suite.cfg

-- 
2.25.0



More information about the Tarantool-patches mailing list