[Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR extension serializer

[Cyrill Gorcunov]

On Tue, May 12, 2020 at 10:38:25PM +0200, Vladislav Shpilevoy wrote:
...
> > 
> > Don't get it -- include current file?! This a good sign of
> > some kind of problem in the code structure... If we need
> > a template then it should be some .cc/.c file explicily
> > included instead of __FILE__, no?
> 
> I don't want to introduce a new file just for these 2 functions
> (mp_fprint_error() and mp_snprint_error()). This would be even
> worse than it is now. So I used the same file. I wrote __FILE__
> instead of mp_error.cc, so as to minimize diff, when mp_error.cc
> will be converted to C and moved to lib/core (that is planned).
> Also #include __FILE__ is more clear, when you want to say
> "include self", IMO.

OK, thanks for the long explanation, Vlad! I trimmed the mail
to not overquote. As to alignments and the rest -- up to you
(hopefully Sergey and Nikita will take look as well).