[Tarantool-patches] [PATCH 0/7] box/console: add support for internal types

Cyrill Gorcunov gorcunov at gmail.com
Fri May 8 19:19:10 MSK 2020


On Fri, May 08, 2020 at 07:04:26PM +0300, Oleg Babin wrote:
> Hi! Thanks for patchset! I have a few comments.
> 
> I'm not sure that we should return errors in such way:
> ```
> tarantool> x
> {error = "[string \"return x\"]:1: variable \'x\' is not declared"};
> ```

Yes. This allows to paste the result back to the console.
This is change in behaviour but while we're not claiming
that th lua mode is stable I think we can do so.

> 
> Or is it expected behaviour?
> 
> Also `nil` value is ignored in some cases.
> ```
> tarantool> nil
> ;
> tarantool> nil, 2, 3
> ;
> tarantool> 1, nil, 3
> 1, nil, 3;
> ```

Thanks! I'll take a look.

> 
> And I've met strange output:
> ```
> tarantool> box.space.test.index
> {[0] = {unique = true, parts = {{type = "integer", is_nullable = "false",
> fieldno = "3"}, {type = "unsigned", is_nullable = "false", fieldno = "5"}},
> type = "TREE", id = "0", space_id = "520", name = "id"}, [1] = {unique =
> false, parts = {{type = "unsigned", is_nullable = "false", fieldno = "1"}},
> id = 1, space_id = 520, type = "TREE", name = "bucket_id"}, [bucket_id]1
>  = !!!*anchor[id]0
>  = !!!*anchor};
> ```
> 
> "!!!*anchor" looks strange. Seems it occurs when you mix map and array.

Yes, this is self reference. I need to revisit this moment. Thank you!


More information about the Tarantool-patches mailing list