[Tarantool-patches] [PATCH v2 02/10] box: rename diag_add_error to diag_set_error

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Mar 26 03:22:56 MSK 2020


Hi! Thanks for the patch!

The commit LGTM. Lets push it right away.

On 25/03/2020 02:42, Nikita Pettik wrote:
> From: Kirill Shcherbatov <kshcherbatov at tarantool.org>
> 
> Let's rename diag_add_error() to diag_set_error() because it actually
> replaces an error object in diagnostic area with a new one and this name
> is not representative. Moreover, we are going to introduce a new
> diag_add_error() which will place error at the top of stack diagnostic
> area.
> 
> Needed for #1148


More information about the Tarantool-patches mailing list