[Tarantool-patches] [PATCH v2 04/10] box/error: introduce box.error.set() method

Nikita Pettik korablev at tarantool.org
Wed Mar 25 20:41:31 MSK 2020


On 25 Mar 11:33, Konstantin Osipov wrote:
> * Nikita Pettik <korablev at tarantool.org> [20/03/25 09:32]:
> > box.error.set(err) sets err to instance's diagnostics area. Argument err
> > is supposed to be instance of error object. This method is required
> > since we are going to avoid adding created via box.error.new() errors to
> > Tarantool's diagnostic area.
> 
> I agree that it's a good idea to separate creation and addition in
> Lua.
> 
> I don't know if it breaks anything, but please search on github
> for box.error.new. This is not easy to do, since github doesn't
> support '.' in searches, so perhaps you should do:

As far as I see, it doesn't break anything: test are passing
as expected; it is not in direct contradictions to documentation.
 
> for each (repo in github/tarntool and moonlibs)
>     git clone repo
>     cd repo
>     git grep -r 'box.error.new' .
> 
> Most likely there is some obscure place  you break.
> 
> -- 
> Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list