[Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield

Konstantin Osipov kostja.osipov at gmail.com
Fri Mar 20 22:40:18 MSK 2020


* Nikita Pettik <korablev at tarantool.org> [20/03/20 21:29]:
> > The problem is pretty minor. The fix is actually not necessarily
> > the best one, too (but seems adequate for 1.10).
> 
> Could you please mention other ways to fix it? I'm still new in vinyl,
> so it would be helpful to me to investigate all possible solutions and
> workarounds. Thanks.

1) I'm really am not motivated to do it after the patch is pushed
   like that.
2) There is vy_mem_pin/vy_mem_unpin which is used to pin the mem
   during yields. Generally the mem we're working with should not
   be kicked out of memory inside vy_build_insert_tuple, except for
   when we deliberately wish it to happen in vy_quota_wait().

-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com


More information about the Tarantool-patches mailing list