[Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield

Konstantin Osipov kostja.osipov at gmail.com
Fri Mar 20 20:45:14 MSK 2020


* Kirill Yukhin <kyukhin at tarantool.org> [20/03/20 18:23]:
> It was mentioned multiple times, that we're using separate
> files for bug fixes (and will go further in future).

This works for gcc where each problem is usually a standalone
compilation unit, and once a compiler has run, it leaves no
memory/no state.

It's as terrible idea for a database, when one test case may
impact another, so putting test cases together has a sum effect.

Not to mention the speed of set up and tear down.

To sum up: yet another arrogant and arbitrary decision done
without due process.

In any case, my comment was not just about that. It was about a
yet another push without a proper second code review and
neglecting the previous reviewer's comments.

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list