[Tarantool-patches] [PATCH v3 1/2] test: cleanup tests code

Igor Munkin imun at tarantool.org
Fri Mar 20 16:46:04 MSK 2020


Sasha,

Thanks for the patch! LGTM except the one general nit: please adjust
test:ok messages considering those I proposed in the previous review.

New series is not needed, just update the remote branch.

On 20.03.20, Alexander V. Tikhonov wrote:
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
> 
> Part of #4655
> ---
>  test/fix_string_find_recording.test.lua  |  6 +++---
>  test/fold_bug_LuaJIT_505.test.lua        |  7 ++++---
>  test/fold_bug_LuaJIT_524.test.lua        |  4 ++--
>  test/gh.test.lua                         |  8 ++++----
>  test/table_chain_bug_LuaJIT_494.test.lua | 23 ++++++++++++-----------
>  test/unsink_64_kptr.test.lua             |  7 ++++---
>  6 files changed, 29 insertions(+), 26 deletions(-)
> 

<snipped>

> -- 
> 2.17.1
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list