[Tarantool-patches] [PATCH v15 03/11] box/txn: move fiber_set_txn to header

Cyrill Gorcunov gorcunov at gmail.com
Fri Mar 20 13:17:36 MSK 2020


On Fri, Mar 20, 2020 at 01:13:35PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [20/03/20 11:20]:
> > We will use it inside wal engine.
> > 
> > Moreover we already have a "get" function in this header
> > which is named in_txt(). Having both get/set in one place
> > should be more consistent.
> > 
> > Acked-by: Konstantin Osipov <kostja.osipov at gmail.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> > ---
> >  src/box/txn.c | 6 ------
> >  src/box/txn.h | 7 +++++++
> >  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> You could drop this commit now perhaps.

While it is not longer used in wal. I think it is more
consistent to have set/get functions in one place?

Thus if you're not strictly against I would keep it
(except I need to update the changelog pointing that
 the commit is not because of wal)


More information about the Tarantool-patches mailing list