[Tarantool-patches] [PATCH v2 2/3] fio: close unused descriptors automatically

Igor Munkin imun at tarantool.org
Fri Mar 20 01:53:39 MSK 2020


Vlad,

As you mentioned to me, the doc[1] specify 'userdata' (i.e. opaque type)
as a return type for <fio.open>. Current implementation returns a table,
so as we discussed there is nothing preventing you from dropping all
hacks you used in the patch and implement file handle object via cdata
or userdata.

On 19.03.20, Igor Munkin wrote:
> Vlad,
> 
> Thanks for the patch! I see no flaws in it, except the _gc field
> presence in fio object. I made another solution based on your cool hacks
> with ffi.gc (you can find the diff below). Feel free to disregard my
> changes if the problem doesn't bother you.
> 

<snipped>

> 
> -- 
> Best regards,
> IM

[1]: https://www.tarantool.io/en/doc/2.3/reference/reference_lua/fio/#fio-open

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list