[Tarantool-patches] [PATCH v13 11/11] box/journal: redesign journal operations

[Cyrill Gorcunov]

On Thu, Mar 19, 2020 at 02:12:06PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [20/03/19 13:51]:
> 
> I really it's not worth it, adding a cicrular dependency.
> 
> you can declare struct txn in wal.cc, and pass it around by
> pointer without using the header.
> 
> The whole goal of this refactoring was to move fiber_set_txn() 
> outside wal.cc, to txn.cc.
> 
> Is it still impossible? let's discuss.

Kostya, letme try. I think I can move txn related stuff to
the journal.c, and wal.c won't need it. Gimme some time...

> 
> Module boundaries are really important long term. You add it for a
> valid reason, and some other patch will begin using txn inside wal
> for a silly reason.

Yes, I know what is bothering you and completely agree.