[Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function

[Igor Munkin]

Kostja,

On 19.03.20, Konstantin Osipov wrote:
> * Igor Munkin <imun at tarantool.org> [20/03/19 10:08]:
> > I guess the problem have to be fixed anyway.
> > 
> > However you might suggest another fix for the issue? There are several
> > other ways to indicate whether box is configured, e.g. introduce the
> > specific value to the box table. What do you think?
> 
> Why not set a lua variable *from* C instead of calling from Lua
> *into* C each time?

I guess we talk about the same thing.

> 
> I mean, this is an obvious optimization, but it is only worth it
> if there is a measurable slowdown (which I suspect there is, at
> least a couple of %, but even a couple of % IMHO justify it).

I'm OK with your proposal (but I still don't see the box.cfg as a
performance bottleneck).

Sasha, any thoughts?

> 
> > I see for now box.cfg call as not the one performance critical, but I
> > might be missing something you see.
> > 
> > It would be great if you detailed a bit your proposal regarding the fix
> > and its benchmarks.
> 
> -- 
> Konstantin Osipov, Moscow, Russia

-- 
Best regards,
IM